Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record types for vote commands #395

Merged
merged 7 commits into from
Oct 24, 2023
Merged

Record types for vote commands #395

merged 7 commits into from
Oct 24, 2023

Conversation

newhoggy
Copy link
Contributor

Changelog

- description: |
    Record types for vote commands
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review October 21, 2023 07:18
@newhoggy newhoggy force-pushed the newhoggy/record-types-for-vote-commands branch from 679f439 to 6a47302 Compare October 21, 2023 08:17
@newhoggy newhoggy force-pushed the newhoggy/record-types-for-vote-commands branch from 6a47302 to f839e0f Compare October 21, 2023 08:37
@carlhammann carlhammann mentioned this pull request Oct 23, 2023
Merged
3 tasks
carlhammann
carlhammann approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@carlhammann carlhammann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it's a good clean-up of the code!

@newhoggy newhoggy added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 23, 2023
@carbolymer carbolymer added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 8465389 Oct 24, 2023
19 checks passed
@carbolymer carbolymer deleted the newhoggy/record-types-for-vote-commands branch October 24, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlhammann carlhammann carlhammann approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@carbolymer carbolymer carbolymer approved these changes

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@newhoggy @carbolymer @Jimbo4350 @carlhammann